Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build produces unrunnable Linux binary on OSX #43

Open
rosieyohannan opened this issue Nov 2, 2018 · 2 comments
Open

make build produces unrunnable Linux binary on OSX #43

rosieyohannan opened this issue Nov 2, 2018 · 2 comments

Comments

@rosieyohannan
Copy link
Contributor

Comment from Max from trello card: kubectl uses go env GOARCH and GOOS in its makefile so it detects the OS at run time. Unfortunately it doesn't quite spit out our current string, returning amd64-linux instead of x86_64-linux

@pwaller
Copy link
Contributor

pwaller commented Nov 5, 2018

I don't quite understand the this issue as written.

How can I observe the issue for myself? I might sort of guess that it involves a version string being shown somewhere, perhaps reco? However, I don't see a version string with reco version.

@CampGareth

@CampGareth
Copy link
Contributor

@pwaller iirc this is to do with the makefile setting linux as the default platform:

reco/Makefile

Line 11 in abaa911

TARGET := x86_64-linux

So if you are in the reco repo and run make build on your mac you will iirc end up with a linux binary that you cannot run.

@pwaller pwaller changed the title Fix reco build docs/process to be unsurprising - currently builds linux regardless of host make build produces unrunnable Linux binary on OSX Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants