Change the hover handler upon source ID changing #6381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/recordreplay/devtools/DhkrgpxtmS91DyKWFX5oZirzvNZm |
![replay-soc2[bot]](https://avatars.githubusercontent.com/u/60818315?s=60&v=4){kind=small}
ryanjduffy
approved these changes
Apr 14, 2022
jcmorrow
force-pushed
the
jm-toggle-files-hit-counts
branch
from
2fff235
to
fce63fb
Compare
jcmorrow
force-pushed
the
jm-toggle-files-hit-counts
branch
from
fce63fb
to
70ead45
Compare
✅ QA Wolf - PR deployment
✅ 10 pass |
See
app.replay.io/recording/hit-counts-stuck-loading--12da5073-0dde-41b2-a3ac-9ed2d5b4eb4f?point=101574307311961095129412067018145992&time=38370.53571428572&hasFrames=true
for some detailed diagnosis. Basically: if the LineNumberTooltip does
not remount between file changes, then we continue to request the old
sourceId when retrieving hitCounts. This makes sure that if source.id
has changed we will redefine the setHoveredLineNumber function.
Closes #6380
jcmorrow
force-pushed
the
jm-toggle-files-hit-counts
branch
from
70ead45
to
6a96187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://app.replay.io/recording/hit-counts-stuck-loading--12da5073-0dde-41b2-a3ac-9ed2d5b4eb4f?point=101574307311961095129412067018145992&time=38370.53571428572&hasFrames=true# for some detailed diagnosis. Basically: if the
LineNumberTooltipdoes not remount between file changes, then we continue to request the oldsourceIdwhen retrieving hitCounts. This makes sure that ifsource.idhas changed we will redefine thesetHoveredLineNumberfunction.Closes #6380