Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

takePicture never called #52

Closed
ananduri opened this issue Jul 6, 2017 · 2 comments
Closed

takePicture never called #52

ananduri opened this issue Jul 6, 2017 · 2 comments
Labels

Comments

@ananduri
Copy link

ananduri commented Jul 6, 2017

Hey guys, thanks for this very useful library.

Problem:
When using a Moto G4, I can take a picture once. But the second time I try to take a picture, it doesn't work.

Details:

  • When it fails, I see autoFocus in the Fotoapparat logs, but takePicture never shows up.
  • The OS version was api 25
  • I tried this on 4 phones:
    • Samsung S5: no issue
    • Samsung S6: no issue
    • Moto G: no issue
    • Moto G4: fails
  • Snippet where I initialize fotoapparat:
fotoapparat = Fotoapparat
                .with(this)
                .into(cameraView)
                .lensPosition(back())
                .logger(loggers(logcat()))
                .focusMode(firstAvailable(  
                       continuousFocus(),
                       autoFocus(),        
                       fixed()             
                ))
                .photoSize(wideRatio(biggestSize()))
                .build();
  • If I change the snippet to:
fotoapparat = Fotoapparat
                .with(this)
                .into(cameraView)
                .lensPosition(back())
                .logger(loggers(logcat()))
                .focusMode(autoFocus()) //  <---  this line changed
                .photoSize(wideRatio(biggestSize()))
                .build();

this issue doesn't arise. But then obviously I can't use continuous focus mode.

Unfortunately, I don't have access to the problematic device right now, so I can't do additional testing. If this issue isn't solved because of that, feel free to close it, and I can open an issue again when I get access to the device.

@Diolor Diolor added the bug label Jul 6, 2017
@dmitry-zaitsev
Copy link
Member

Thanks for the report!

We encountered somewhat similar (although not exactly the same) problem on an an emulator, but this is the first time we hear about it happening on a real device. Will try to fix it 👍

@dmitry-zaitsev
Copy link
Member

OK, that was an easy fix. You can expect it in the next version (should be available until the end of the week).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants