Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive: Arguments to CMD in exec for must not contain single quotes #22

Closed
russelltsherman opened this issue Feb 1, 2017 · 2 comments

Comments

@russelltsherman
Copy link

Issue details

dockerlint reports false positive when CMD includes whitespace between brackets and quotes.

Steps to reproduce/test case

add spaces between brackets and quotes triggers this lint error
CMD [ "node" ]

Affected version(s)

0.2.0

@cstrouse
Copy link
Contributor

cstrouse commented Mar 8, 2017

This also occurs without spaces between the bracket and the quotes. Seems to me that the issue is triggered whenever there is a space character anywhere within the brackets.

CMD ["awesome_bot", "README.md", "--allow-dupe", "--allow-redirect", "--allow-ssl", "--allow-timeout", "--allow 999,403,405,500"]

@odivlad
Copy link

odivlad commented Mar 15, 2017

I also have false-positive because of comma symbol in argument, that I should pass to exec:

CMD ["my-executable", "-b", "a,1"]

I see, that it occurs because of split by comma, but I don't know how to fix it correctly...
https://github.com/RedCoolBeans/dockerlint/blame/master/src/checks.coffee#L84

@rnagy rnagy closed this as completed in c0a9975 Apr 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants