Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 0 being displayed empty #17

Merged
merged 4 commits into from Aug 29, 2022
Merged

Fixed 0 being displayed empty #17

merged 4 commits into from Aug 29, 2022

Conversation

Zenithsiz
Copy link
Contributor

If an expression has value 0, you will only see the base (e.g. "0x", or "0b" / "").
This fixed it by adding a '0' character, if the number was 0

If an expression has value 0, you will only see the base (e.g. "0x", or "0b" / "").
This fixed it by adding a '0' character, if the number was 0
@RedDocMD
Copy link
Owner

Nice catch! Thank you for the fix.
Could you please add a test for this? Just to make sure we don't break it again later.

@Zenithsiz
Copy link
Contributor Author

Zenithsiz commented Aug 28, 2022

I wrote some tests, and during noticed that binary numbers use Ob instead of 0b (uppercase 'o' instead of zero).

I changed this to 0b, as I think it's unintentional, but if it is, tell me and I'll remove the commit that does it and adjust the tests

@RedDocMD
Copy link
Owner

I wrote some tests

Nice tests!

I changed this to 0b, as I think it's unintentional

Yes, that's a mistake 😅. Nice catch!

@RedDocMD RedDocMD merged commit c7d04bf into RedDocMD:main Aug 29, 2022
@Zenithsiz Zenithsiz deleted the fix-0 branch September 2, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants