New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements #18 issue/feature, the "to _radix_" command: #19
Conversation
cork> 0xCAFE to dec 51966
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
I have made a few comments. Please look into them.
Also, I think you may need to run your code through rustfmt
.
(pest will issue an appropriate error instead).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 8b94b9e implements the requested changes.
Thank you for the changes! |
You're right, sure, I forgot the tests. Added in the last commit. |
Thanks a lot! I think I will merge it now, since you have covered all bases pretty nicely. |
Implements the "to radix" command to quickly and temporary convert a number or the result of an expression to a different radix (for example when working with memory address and segments sizes):