Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

### FilterChips.tsx #1801

Closed
nicolethoen opened this issue Aug 10, 2023 · 3 comments · Fixed by #1888
Closed

### FilterChips.tsx #1801

nicolethoen opened this issue Aug 10, 2023 · 3 comments · Fixed by #1888
Assignees
@kmcfaul
Labels
css review needed
Projects
PF4@5 migration

Comments

@nicolethoen
Copy link
Contributor

file: https://github.com/RedHatInsights/frontend-components/tree/master/packages/components/src/FilterChips/FilterChips.tsx

Ensure PF4@5 compatibility
@nicolethoen nicolethoen created this issue from a note in PF4@5 migration (To do) Aug 10, 2023
@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 10, 2023

👍

@nicolethoen nicolethoen moved this from To do to In progress in PF4@5 migration Aug 10, 2023
@kmcfaul
Copy link
Contributor

kmcfaul commented Aug 10, 2023

Minor margin difference that may require an update. Need a core dev to verify if it's on our end (looks like v5 isn't including a --pf-c-chip__c-badge--MarginLeft, or we removed it intentionally?)

Master:
image

pf4@5:
image

@nicolethoen nicolethoen added help wanted Extra attention is needed css review needed and removed help wanted Extra attention is needed labels Aug 10, 2023
@kmcfaul kmcfaul mentioned this issue Aug 10, 2023
Closed
@nicolethoen
Copy link
Contributor Author

I think we might be able to provide a quick CSS override to add some marginLeft as a quick fix in this case.

@nicolethoen nicolethoen mentioned this issue Aug 14, 2023
Merged
@nicolethoen nicolethoen moved this from In progress to PR open in PF4@5 migration Aug 14, 2023
@nicolethoen nicolethoen linked a pull request Aug 14, 2023 that will close this issue
fix: various tweaks to clean up v5 migration #1888
Merged
@Hyperkid123 Hyperkid123 moved this from PR open to Done in PF4@5 migration Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcfaul kmcfaul

Labels
css review needed
Projects
PF4@5 migration
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: various tweaks to clean up v5 migration nicolethoen/frontend-components
3 participants
@Hyperkid123 @nicolethoen @kmcfaul