Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-5503): Objects modal cypress tests #702

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Mar 6, 2024

@Fewwy Fewwy added the tests label Mar 6, 2024
@Fewwy Fewwy self-assigned this Mar 6, 2024
@Fewwy Fewwy requested a review from a team as a code owner March 6, 2024 12:04
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 8.15%. Comparing base (853fb75) to head (c10c415).
Report is 2 commits behind head on master.

Files Patch % Lines
src/Components/ObjectsModal/ObjectsModal.cy.js 0.00% 56 Missing ⚠️
src/Components/Workload/Workload.cy.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #702      +/-   ##
=========================================
- Coverage    8.29%   8.15%   -0.15%     
=========================================
  Files          67      68       +1     
  Lines        3615    3680      +65     
  Branches      813     816       +3     
=========================================
  Hits          300     300              
- Misses       3315    3380      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, well done 😄

@Fewwy Fewwy merged commit 6956d87 into RedHatInsights:master Mar 8, 2024
2 checks passed
@gkarat
Copy link
Collaborator

gkarat commented Mar 8, 2024

🎉 This PR is included in version 1.39.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@gkarat gkarat added the released label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants