Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(RHINENG-7049): fec config setup #720

Merged
merged 2 commits into from
Mar 26, 2024
Merged

feat(RHINENG-7049): fec config setup #720

merged 2 commits into from
Mar 26, 2024

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Mar 26, 2024 •
edited

@Fewwy Fewwy added the enhancement New feature or request label Mar 26, 2024
@Fewwy Fewwy self-assigned this Mar 26, 2024
@Fewwy Fewwy requested a review from a team as a code owner March 26, 2024 12:37
@Fewwy
Copy link
Collaborator Author

Fewwy commented Mar 26, 2024

/retest

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.90%. Comparing base (273f87a) to head (1d83301).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #720      +/-   ##
=========================================
- Coverage    8.07%   7.90%   -0.17%     
=========================================
  Files          68      68              
  Lines        3703    3782      +79     
  Branches      818     825       +7     
=========================================
  Hits          299     299              
- Misses       3404    3483      +79

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AsToNlele
AsToNlele approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@AsToNlele AsToNlele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried all the environments, all working, LGTM 😄

@Fewwy Fewwy merged commit 4b1257e into RedHatInsights:master Mar 26, 2024
2 checks passed
@gkarat
Copy link
Collaborator

gkarat commented Mar 27, 2024

🎉 This PR is included in version 1.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsToNlele AsToNlele AsToNlele approved these changes

Assignees

@Fewwy Fewwy

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fewwy @codecov-commenter @gkarat @AsToNlele