fix(RHINENG-8615): Fix "View ${n} affected clusters" link missing #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
=========================================
- Coverage 7.77% 7.74% -0.03%
=========================================
Files 68 68
Lines 3847 3860 +13
Branches 835 837 +2
=========================================
Hits 299 299
- Misses 3548 3561 +13 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
🎉 This PR is included in version 1.42.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/RHINENG-8615.
This replaces the deprecated "showViewAffected" flag and passes "ViewAffectedLink" node instead. This fixes the link missing in the expanded rule details.
How to test
Go to /openshift/insights/recommendations, makes sure you can see "View affected clusters" in the expanded details for impacting recommendations. The link must not appear for non-impacting rules.