Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ESSNTL-3717): Integrate groups with /systems #1959

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

gkarat
Copy link
Contributor

@gkarat gkarat commented Aug 31, 2023

Implements https://issues.redhat.com/browse/ESSNTL-3717.

This integrates the group filter and column with the /systems page. The column Group shows a group of each system: if it is not a member of any group, then 'N/A' is rendered, otherwise the name of the group. Also, users now can filter by group(s).

How to test

Verify basic filtering by the groups, and make sure the group names are mapped correctly to each host.

Screenshots

Screenshot 2023-08-31 at 20 35 07

@gkarat gkarat added the enhancement New feature or request label Aug 31, 2023
@gkarat gkarat requested a review from a team as a code owner August 31, 2023 18:35
@gkarat gkarat self-assigned this Aug 31, 2023
@jira-linking
Copy link

jira-linking bot commented Aug 31, 2023

Commits missing Jira IDs:
45f81a6
73a5c35

@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
src/Helpers/APIHelper.js ø
src/Helpers/Hooks.js 0.00%
src/Helpers/constants.js 0.00%

📢 Thoughts on this report? Let us know!.

Copy link
Member

@leSamo leSamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

@gkarat gkarat merged commit 75154a4 into RedHatInsights:master Aug 31, 2023
4 checks passed
@gkarat gkarat deleted the essntl-3717 branch August 31, 2023 19:02
leSamo pushed a commit that referenced this pull request Aug 31, 2023
# [1.103.0](v1.102.2...v1.103.0) (2023-08-31)

### Features

* **ESSNTL-3717:** Integrate groups with /systems ([#1959](#1959)) ([75154a4](75154a4))
Jason-RH pushed a commit to RedHatInsights/vulnerability-ui-build that referenced this pull request Aug 31, 2023
# [1.103.0](RedHatInsights/vulnerability-ui@v1.102.2...v1.103.0) (2023-08-31)

### Features

* **ESSNTL-3717:** Integrate groups with /systems ([#1959](RedHatInsights/vulnerability-ui#1959)) ([75154a4](RedHatInsights/vulnerability-ui@75154a4))
LiorKGOW pushed a commit to LiorKGOW/vulnerability-ui that referenced this pull request Jan 8, 2024
…HatInsights#1959)

* fix(bug): inventory table access with no read permission

* fix(rbac): fixed the error notification

* fix(rbac): added a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants