Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podman compose results user owned #8

Conversation

cedricbu
Copy link
Collaborator

@cedricbu cedricbu commented Apr 8, 2022

Podman 3.1.0 and above support the "U" flag to change ownership of
volumes.
This makes the `unshare chown` unecessary when using podman >= 3.1
IIUC, it does not affect older versions, which will simply ignore the
unknown flag.

@lpardoRH
Copy link
Collaborator

LGTM but README file should be updated to remove the unshare directive

@cedricbu
Copy link
Collaborator Author

Oh, yes, good point, I forgot that. I updated it.

... Also, I see that the "Warns when uploading a policy that exists already" accidentally found its way into this branch :/ ....

Podman 3.1.0 and above support the "U" flag to change ownership of
volumes.
This makes the `unshare chown` unecessary when using podman >= 3.1
IIUC, it does not affect older versions, which will simply ignore the
unknown flag.
@cedricbu cedricbu force-pushed the podman_compose_results_user_owned branch from 9543cfc to bdc1b6e Compare April 13, 2022 15:33
@cedricbu
Copy link
Collaborator Author

:) all cleaned up.

  • I removed the changes that I accidentally sneaked up ("Warns when uploading a policy that exists already", which belonged to another PR)
  • modified the podman-compose files for automatically changing the ownership
  • commented the README about the change

@lpardoRH
Copy link
Collaborator

LGTM @jeremychoi

@jeremychoi jeremychoi merged commit 740d1e8 into RedHatProductSecurity:master May 4, 2022
@cedricbu cedricbu deleted the podman_compose_results_user_owned branch May 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants