Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fragment-args-ktx: Parameter default shouldn't be calculated if key is present in arguments #31

Closed
osipxd opened this issue Sep 30, 2021 · 0 comments · Fixed by #32
Closed
Assignees
Labels
bug Something isn't working

Comments

@osipxd
Copy link
Member

osipxd commented Sep 30, 2021

For example following code will always crash on getting value:

var id by arguments.long(default = { error("Field 'id' required to be set") })

Because of line 450:
https://github.com/RedMadRobot/redmadrobot-android-ktx/blob/a0372778a816b01d2251ecb056c3f3fed7f15348/fragment-args-ktx/src/main/kotlin/FragmentArgsDelegates.kt#L447-L450

@osipxd osipxd self-assigned this Sep 30, 2021
@osipxd osipxd added the bug Something isn't working label Sep 30, 2021
@osipxd osipxd closed this as completed in 910d335 Oct 2, 2021
@osipxd osipxd closed this as completed in #32 Oct 2, 2021
@osipxd osipxd mentioned this issue Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant