Skip to content
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.

Warning about too many tactics in [_, _, ..., _] #592

Closed
favonia opened this issue Feb 12, 2018 · 4 comments
Closed

Warning about too many tactics in [_, _, ..., _] #592

favonia opened this issue Feb 12, 2018 · 4 comments

Comments

@favonia
Copy link
Contributor

favonia commented Feb 12, 2018

The trailing tactics in [t1, t2, t3, ..., tn] will not run if the number of subgoals is less then the number of tactics, and that should generate a warning.

@jonsterling
Copy link
Contributor

@favonia I'm not sure if it really should generate a warning, because the shape of the proof state is dynamic. But I'm not strongly against it either...

@favonia
Copy link
Contributor Author

favonia commented Feb 13, 2018

I think it is confusing if part of the script is silently ignored. The warning will be generated dynamically. Maybe I misunderstood your concern? Are you worried about the tactic defined in the userland?

@jonsterling
Copy link
Contributor

@favonia I guess I was thinking that one doesn't want a script to depend that sharply on the actual structure of the proof state, but now I think you're right and I was wrong.

With that said, what I think we do want to allow is to provide fewer tactics than needed; for instance [t1,t2] should be fine, even if there are four subgoals. But we can make a warning if there are too many tactics provided.

@favonia
Copy link
Contributor Author

favonia commented Feb 13, 2018

Yes: being lazy is fine, but working too hard is a serious problem.

@favonia favonia changed the title Warning about unused tactics in [t1, t2, t3, ..., tn] Warning for providing too many tactics in [_, _, ..., _] Feb 19, 2018
@favonia favonia changed the title Warning for providing too many tactics in [_, _, ..., _] Warning for too many tactics in [_, _, ..., _] Feb 19, 2018
@favonia favonia changed the title Warning for too many tactics in [_, _, ..., _] Warning about too many tactics in [_, _, ..., _] Apr 19, 2018
@favonia favonia closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants