Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove min row # requirement when initializing collective.js.datatables #16

Closed
petri opened this issue Sep 9, 2014 · 1 comment
Closed

Comments

@petri
Copy link
Member

petri commented Sep 9, 2014

There's the hard-coded requirement in tablepage.js that says only enable DataTables when there are at least 4 rows. For users it's very confusing - they expect it to always be enabled.

It's a subjective matter anyway - choosing some min # of rows is matter of personal preference - so IMHO, this requirement should be removed. Just always enable DataTables JS.

Or, at least let's make the min count configurable.

@keul
Copy link
Member

keul commented Sep 10, 2014

Removing this hack seems fair to me. For what I remember: I added it because when you have few rows you'll see a very tiny table area with a vertical scroll bar and I was unable to find a way to enlarge it.

But yes, it can really confusing users

@keul keul closed this as completed in 715e635 Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants