Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not uninstalling cleanly? #1

Closed
jmce opened this issue Jul 5, 2012 · 8 comments
Closed

Not uninstalling cleanly? #1

jmce opened this issue Jul 5, 2012 · 8 comments
Labels

Comments

@jmce
Copy link

jmce commented Jul 5, 2012

In a couple of Plone 4.1.5 sites, after removing all [smart]link objects, I disabled redturtle.smartlink, packed the Data.fs, removed the product entry in buildout.cfg and ran buildout, but still got these warnings in the instance.log (until I included redturtle.smartlink in buildout.cfg again) :
WARNING OFS.Uninstalled Could not import class 'SmartLink' from module 'redturtle.smartlink.content.link'
WARNING OFS.Uninstalled Could not import class 'SmartlinkConfig' from module 'redturtle.smartlink.utility'

One interesting detail: in one of those sites, after the above, I created a new link with the same id (and in the same folder) of one of the previously existing links (a link to an image object, which to my surprise was originally using flowplayer to show the image linked to when visting the link object). The bigger surprise was that the freshly created link object (now just a classic Link object) was also using flowplayer to show the target image (and, unexpectedly, actually not redirecting visitors to the image object, a strange behaviour I had noticed with redturtle.smartlink installed). Visiting the link object with the ZMI, I noticed this was because it had a "layout" property (with value "flowplayer", if I remember correctly). But this did NOT happen if I created similar link objects with different new ids (no layout property in those) --- somehow, Zope/Plone retained some memory of the layout property associated with the old [smart]link's id (until I removed the property in the new link via the ZMI), even though I had packed Data.fs with the smartlink already deleted. Maybe some interaction with redturtle.video? In case it's helpful the eggs section is currently

eggs =
Plone
Pillow
lxml
artenumerica.ludus2locales == 0.5
collective.portletpage
collective.panels
collective.prettyphoto
webcouturier.dropdownmenu
Solgema.fullcalendar
Solgema.NavigationPortlet
fourdigits.portlet.twitter
redturtle.video
collective.rtvideo.youtube
collective.rtvideo.vimeo
collective.rtvideo.metacafe
redturtle.smartlink
experimental.pietimemenu
Products.CMFPlomino
plomino.tinymce
redomino.css3theme

For now I'm keeping redturtle.smartlink in buildout.cfg, even though not using it, just in case there may be any side effects of its absence beyond the warning messages...

Actually, the incident of the link to an image trying to show the target image with flowplayer, instead of redirecting to the image (those visitors unable to edit the link), would deserve a separate issue entry here --- but it's now hard for me to do further testing until I have time to play with smartlink in a fresh separate Plone instance...

@keul
Copy link
Contributor

keul commented Jul 5, 2012

We will check this, thanks for reporting and analysis

@jmce
Copy link
Author

jmce commented Jul 5, 2012

Thanks! Meanwhile, I just noticed that:

  • in other Plone sites I have "Active baseline: profile-Products.CMFPlone:plone" in the portal_setup Profiles tab;
  • but the 2 sites where I had installed and later disabled redturtle.smartlink, show "Active baseline: profile-redturtle.smartlink:uninstall" instead, as the "baseline profile".

I'm not sufficiently acquainted with Plone mechanics to know how much of a problem (if any) this may be... Mentioning it in case it may be helpful too.

@keul
Copy link
Contributor

keul commented Jul 8, 2012

Meanwhile: I found the other problem you reported (change of baseline). It's a bug in the uninstall procedure.

We will fix this also

@keul keul closed this as completed in 83a73a7 Sep 13, 2012
@keul
Copy link
Contributor

keul commented Sep 13, 2012

Going back to your problem: the "interesting detail" you reported can't be a problem of Smart Link (and yes: old flowplayer versions were using the flowplayer view to display images. I fixed it some month ago).

You report two missing utility:

  • 'SmartLink' from module 'redturtle.smartlink.content.link'
  • 'SmartlinkConfig' from module 'redturtle.smartlink.utility'

The second one has been fixed in the 1.1.3 release (I will release it today). The first ones: seems simply you didn't removed all Smart Link contents.

If not: I can't reproduce the problem, sorry.

Baseline context change: fixed also

Thanks for your report

@jmce
Copy link
Author

jmce commented Sep 19, 2012

Thanks! I'll upgrade asap.

@jmce
Copy link
Author

jmce commented Sep 27, 2012

Installing the most recent redturtle.smartlink release and removing it again (after having created some additional links) seemed to go ok [links converted back, etc.] but I noticed now (while installing redturtle.portlet.collection, but maybe this is not much relevant) these two messages showing up in instance.log:
2012-09-27T18:44:35 ERROR GenericSetup Step smartLinkToATLink has an invalid import handler
2012-09-27T18:44:35 ERROR GenericSetup Step imaged-event has an invalid import handler
(among other INFO ones, perhaps not relevant -- let me know if more info could be useful...)
[NOTE: in this case, I had already removed the redturtile.smartlink egg entry from buildout.cfg, after deactivating in Plone]

@jmce
Copy link
Author

jmce commented Sep 27, 2012

Via ZMI, portal_setup, tab "Manage": 2 "steps with invalid step handlers":
SmartLink - various import steps [redturtle.smartlink.setuphandlers.setupVarious]
Smart Link: migrate from Smart Link back to ATLink [redturtle.smartlink.setuphandlers.smartLinkToATLink]

I suppose I may simply delete these steps there (but still haven't)...

@keul
Copy link
Contributor

keul commented Sep 28, 2012

Yes, you can remove them manually without problem, however there's still something we can change there (an useless import step)

@keul keul reopened this Sep 28, 2012
@keul keul closed this as completed in 0a32be1 Feb 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants