Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EX and PX options to JSON.SET #913

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add EX and PX options to JSON.SET #913

wants to merge 4 commits into from

Conversation

gkorland
Copy link
Contributor

Ref #415

@gkorland gkorland linked an issue Jan 15, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 81.36% // Head: 81.36% // No change to project coverage 👍

Coverage data is based on head (b458d28) compared to base (b458d28).
Patch has no changes to coverable lines.

❗ Current head b458d28 differs from pull request most recent head 435cd84. Consider uploading reports for the commit 435cd84 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #913   +/-   ##
=======================================
  Coverage   81.36%   81.36%           
=======================================
  Files          15       15           
  Lines        3896     3896           
=======================================
  Hits         3170     3170           
  Misses        726      726           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gkorland gkorland marked this pull request as ready for review January 19, 2023 17:16
@gkorland gkorland requested a review from oshadmi January 19, 2023 17:17
@bjwschaap
Copy link

Any indications on as when this will be merged?

@PaulAtkins88
Copy link

bump on this PR

@timeimp
Copy link

timeimp commented Mar 11, 2024

I was expected a 1:1 match with the SET command for JSON.SET - imagine my confusion when the EX value was never accepted!

Is there an outstanding item preventing merge? Would really like to see this normal EX value be set on JSON.SET commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for JSON.SET + custom ttl (JSON.SETEX)
5 participants