Skip to content
This repository has been archived by the owner on Aug 22, 2020. It is now read-only.

Process data in order to implement category based searching #5

Closed
Redmega opened this issue Oct 12, 2018 · 8 comments
Closed

Process data in order to implement category based searching #5

Redmega opened this issue Oct 12, 2018 · 8 comments
Labels
enhancement New feature or request Hacktoberfest Great issue for Hacktoberfest! in progress Issues currently being worked on

Comments

@Redmega
Copy link
Owner

Redmega commented Oct 12, 2018

Blocks #1.

Data needs to be processed more. Instead of passing the array of values directly through, ideally each counselor collection needs to be converted to an object. Similar fields should be combined by type (E.g. Mailing address fields / practice address fields.

Mailing Address: 6 fields
Number: 2 fields
Practice Address: 5 fields

If we can combine these together, we can display them better.

@Redmega Redmega added enhancement New feature or request Hacktoberfest Great issue for Hacktoberfest! and removed Hacktoberfest Great issue for Hacktoberfest! labels Oct 12, 2018
@dsych
Copy link
Contributor

dsych commented Oct 14, 2018

Hey @Redmega do you mind if I give it a go?

@Redmega
Copy link
Owner Author

Redmega commented Oct 15, 2018

Go for it! I thought I was going to work on it so I removed the Hacktoberfest label, but I'll add it back. :)

@Redmega Redmega added the Hacktoberfest Great issue for Hacktoberfest! label Oct 15, 2018
@Redmega Redmega changed the title Implement category based searching Process data in order to implement category based searching Oct 15, 2018
@Redmega
Copy link
Owner Author

Redmega commented Oct 15, 2018

If you need any help, let me know! I'm here as a sounding board

@Redmega Redmega added the in progress Issues currently being worked on label Oct 15, 2018
@dsych
Copy link
Contributor

dsych commented Oct 16, 2018

cellRenderer seems to be designed to work with arrays. If we were to convert incoming data from array to an object, I am not exactly sure how that is going to work.

@dsych
Copy link
Contributor

dsych commented Oct 16, 2018

Nvm, there is a dataKey

@Redmega
Copy link
Owner Author

Redmega commented Oct 16, 2018

Yep! I believe that was the intent behind that prop -- to make working with arrays of objects easier.

@Redmega
Copy link
Owner Author

Redmega commented Oct 21, 2018

@dsych How is this coming along? Had the chance to work on it? Need any help?

@dsych
Copy link
Contributor

dsych commented Oct 21, 2018

sorry for the holdup, I opened the PR #8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Hacktoberfest Great issue for Hacktoberfest! in progress Issues currently being worked on
Projects
None yet
Development

No branches or pull requests

2 participants