Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace minimatch with zero-dep picomatch #635

Closed
RomanHotsiy opened this issue Apr 12, 2022 · 3 comments
Closed

Replace minimatch with zero-dep picomatch #635

RomanHotsiy opened this issue Apr 12, 2022 · 3 comments

Comments

@RomanHotsiy
Copy link
Member

Describe the solution you'd like
Replace minimatch module with zero-dep picomatch: https://www.npmjs.com/package/picomatch

Additional context
Less dependencies is always good.

@lornajane
Copy link
Collaborator

Does this still seem relevant @RomanHotsiy ? I realise this one has been open a while

@RomanHotsiy
Copy link
Member Author

I remember someone tried it but for some reason it didn't work out. @tatomyr do you remember it maybe? Or am I confusing something?

@RomanHotsiy
Copy link
Member Author

But I just checked it more. I think we should stick with minimatch.
The bundle size is same, picomatch is 2x faster though, but we're not using it on hot path.

I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants