-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeclared dependencies with Yarn PnP #947
Comments
Hi @Jul13nT, What are these intermediary steps 3-5 for? |
By default Yarn will not use it's last version and it's PnP mode when converting an existing repo from NPM to Yarn. Step 3 is to use Yarn 3.x instead of Yarn 1.22. To confirm you are using the good setup, when running I can reproduce these steps using the feature Open in codespace of GitHub. |
Thanks, for anyone who don't want to set this param, another workaround I found is to set this in packageExtensions:
styled-components@5.3.3:
dependencies:
react-is: "18.2.0"
"@redocly/cli@^1.0.0-beta.114":
dependencies:
"lodash.isequal": "^4.5.0"
"node-fetch": "^2.6.1"
redoc@~2.0.0:
dependencies:
call-me-maybe: "1.0.2"
yaml: "2.1.3"
fast-safe-stringify: "2.1.1" |
Do we need to make code or docs changes to complete the request here? |
Yes, we have to add missing deps to our package.json. We won't be able to add |
@tatomyr we also need to check why redoc package requires |
Describe the bug
I'm unable to install redocly in devDependencies and use it with Yarn Pnp mode. It shows an error for undeclared dependencies.
To Reproduce
Steps to reproduce the behavior:
yarn
yarn set version stable
yarn install
nodeLinker: node-modules
from.yarnrc.yml
file to use PnP mode.yarn install
again.yarn test
Expected behavior
With the cloned repo openapi-starter, running
yarn test
should lint the openapi file instead of throwing an error.Logs
Redocly Version(s)
1.0.0-beta.112, 1.0.0-beta.114
Node.js
Version(s)14.20.1, 18.12.1
Yarn Version(s)
3.3.0, 3.2.4
Additional context
Additionally, when running
yarn install
, Yarn warns on missing peer dependencies:The text was updated successfully, but these errors were encountered: