Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show reserved rockets #53

Merged
merged 6 commits into from Feb 8, 2023
Merged

Show reserved rockets #53

merged 6 commits into from Feb 8, 2023

Conversation

Fahim-Khan-P
Copy link
Collaborator

I've added the following addition

  • create list of reserved rockets from redux store using useSelectore() hook
  • render reserved rockets list to the MyProfile section
  • add style to the reserved rockets list

Copy link
Owner

@ReemMohamedAbdelfatah ReemMohamedAbdelfatah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Fahim-Khan-P 👋,

This is @ReemMohamedAbdelfatah your code reviewer 👩‍💻

Status: Approved ✔️ ✔️ ✔️

Hurray!!!

Good job implementing the requirements 👍 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

MinionsGIF

Highlights!

No linter errors ✔️
Descriptive Pull Request✔️
Apply the requirements perfectly ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

@Fahim-Khan-P Fahim-Khan-P merged commit 19e30eb into development Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants