Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused value? #243

Closed
TarcioV opened this issue Feb 28, 2018 · 0 comments · Fixed by #832
Closed

Unused value? #243

TarcioV opened this issue Feb 28, 2018 · 0 comments · Fixed by #832
Assignees

Comments

@TarcioV
Copy link
Contributor

TarcioV commented Feb 28, 2018

lapack/SRC/dbdsqr.f

Lines 456 to 468 in 4f7f2aa

SMAX = ABS( D( M ) )
SMIN = SMAX
DO 70 LLL = 1, M - 1
LL = M - LLL
ABSS = ABS( D( LL ) )
ABSE = ABS( E( LL ) )
IF( TOL.LT.ZERO .AND. ABSS.LE.THRESH )
$ D( LL ) = ZERO
IF( ABSE.LE.THRESH )
$ GO TO 80
SMIN = MIN( SMIN, ABSS )
SMAX = MAX( SMAX, ABSS, ABSE )
70 CONTINUE

At the end of the loop, SMIN is the absolute of the digonal minimum value, but its value is never used, I wonder why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants