Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lamp Causes Light Leak Through Hatches After Open & Close #12087

Open
1 of 2 tasks
brand175 opened this issue May 27, 2023 · 1 comment
Open
1 of 2 tasks

Lamp Causes Light Leak Through Hatches After Open & Close #12087

brand175 opened this issue May 27, 2023 · 1 comment
Assignees
Labels
Bug Something isn't working Code Programming task

Comments

@brand175
Copy link

brand175 commented May 27, 2023

Disclaimers

  • I have searched the issue tracker to check if the issue has already been reported.
  • My issue happened while using mods.

What happened?

The lamp, when you open and close a hatch with buttons, the light will keep shining through the hatch even when it's closed. Example: Room is somewhat lit, you open the hatch with buttons, now the room is brighter, close the hatch and the room stays lit

Untitled.mp4

Reproduction steps

Shown in video

Screenshot 2023-05-27 122553

Bug prevalence

Happens every time I play

Version

v1.0.13.2

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

light issue.zip

@brand175 brand175 changed the title Certain Lamp Causes Light Leak Through Hatches After Open & Close Lamp Causes Light Leak Through Hatches After Open & Close (Unknown Cause?) May 27, 2023
@Regalis11 Regalis11 self-assigned this May 29, 2023
@Regalis11 Regalis11 added Bug Something isn't working Code Programming task labels May 29, 2023
@Regalis11
Copy link
Collaborator

Thank you for the report!

I gave this a test, and it seems to be caused by how the lighting system marks convex hulls (things that cast shadows) as "hidden" from the light's point of view if they're behind a wall or an obstacle. The issue here is the door goes behind the floor structure when it's closing, marking it as "hidden", and the light will ignore it from that point onwards. Need to think a bit about a way to address this (forcing the door to become "unhidden" for all lights whenever it opens/closes wouldn't be ideal, because it'd significantly increase the amount of light calculations and be bad for performance).

@Regalis11 Regalis11 changed the title Lamp Causes Light Leak Through Hatches After Open & Close (Unknown Cause?) Lamp Causes Light Leak Through Hatches After Open & Close May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task
Projects
None yet
Development

No branches or pull requests

2 participants