Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report buttons not sending an output to wifi components #7542

Closed
1 task done
SeaverBeaver opened this issue Nov 29, 2021 · 5 comments
Closed
1 task done

Report buttons not sending an output to wifi components #7542

SeaverBeaver opened this issue Nov 29, 2021 · 5 comments
Assignees
Labels
Bug Something isn't working Code Programming task

Comments

@SeaverBeaver
Copy link

SeaverBeaver commented Nov 29, 2021

  • I have searched the issue tracker to check if the issue has already been reported.

Description
The report buttons, (Fire, Leak, Broken Devices, etc) don't send a detectable output to chat when pressed. You can see the chat message pop up, but WiFi components cant detect them, so you can't do anything with them.

Steps To Reproduce
Open the submarine editor.
-Wire a linked-to-chat WiFi component to a text display.
-Type something in radio chat, watch it appear on the text display.
-Press one of the report buttons, watch the message appear in chat, but the text display not show the message.

Version
Barotrauma v0.15.13.0 (the release version)

Additional information
I encountered this when attempting to make an intruder alert that would trigger when the "Report Intruders" button was pressed, I figured making a system that could function based off off of the incredibly convenient report buttons could save precious time in an emergency.

@Regalis11 Regalis11 added Bug Something isn't working Code Programming task labels Nov 29, 2021
@ekqvist ekqvist self-assigned this Nov 28, 2022
@ekqvist ekqvist removed their assignment Jan 2, 2023
@Regalis11 Regalis11 self-assigned this Jan 12, 2023
@Regalis11 Regalis11 changed the title Report buttons not sending an output to chat. Report buttons not sending an output to wifi components Jan 12, 2023
@Regalis11
Copy link
Collaborator

@ekqvist ekqvist self-assigned this Jan 17, 2023
@ekqvist
Copy link

ekqvist commented Jan 17, 2023

Tested in singleplayer and multiplayer. Report messages seem to appear on the text displays (i.e. they are sent to the wifi components) now.

However, I did notice (at least in multiplayer, but could be an issue in singleplayer too) that sometimes the report message is different in chat and on the text display. Not sure if it's anything to address, but just noting this down. (IIRC there's logic that only gets the text for the message after the order message is received.)

Moving back to the Team 2 pipeline for you to determine what to do with this.

@ekqvist
Copy link

ekqvist commented Jan 17, 2023

Tested again after the latest commit. The messages seem to be identical now in chat and on the displays. However, I noticed while also testing Regalis11/Barotrauma-development#1602 that after another player joins the lobby (while the first already has a game started) the report messages stop appearing the chat of the reporting player. They still appear in the text displays and in the chat of the second player in the lobby. But the player reporting them doesn't get them in their chat. It seems to fix itself after a while, after spamming the reports for some time.

@Regalis11
Copy link
Collaborator

@ekqvist
Copy link

ekqvist commented Jan 19, 2023

Issues fixed. Has been merged to dev now. Closing.

@ekqvist ekqvist closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task
Projects
None yet
Development

No branches or pull requests

3 participants