[Unstable] Vote kicking a player then removing the ban via lobby settings results in an immediate re-ban on rejoin

[NilanthAnimosus]

Disclaimers

• I have searched the issue tracker to check if the issue has already been reported.
• My issue happened while using mods.

What happened?

I votekicked a client in my server. then used the settings button as a client with all permissions and commands in the lobby to unban the player. however upon joining they are simply banned again automatically.

Reproduction steps

1. Start a server (In my case I used a dedicated)
2. Get 3 clients or more to join
3. use two clients to vote kick the third
4. With one of the two clients, access the settings menu in the lobby on the banlist tab
5. Due to another issue, you may need to open this twice to show the ban
6. use the "Remove" button for the third clients ban that was vote kicked.
7. have the third client rejoin - Find they are given an error or a notification they are banned.
8. the ingame chat for other clients indicates they are banned again.
9. the entry will reappear in the banlist (after opening it twice due to another issue)

Bug prevalence

Happens every time I play

Version

0.19.1.0 (unstable)

-

No response

Which operating system did you encounter this bug on?

Windows

Relevant error messages and crash reports

Error message that sometimes appears (Instead of X is banned):

Messages after being unbanned (all shown are a single rejoin after the unban):

[juanjp600]

Should be fixed in https://github.com/Regalis11/Barotrauma-development/commit/f518331ffa4fef123c70ab8e783221e0215bc69b

[NilanthAnimosus]

Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/7f3f6c800271e4dbdc682bb79cdd4e7e6c074a11

Players are still immediately banned upon rejoining after the ban has been removed from a votekick, and the fix does appear to be in the branch so it appears something else is still causing this.

[Regalis11]

Fixed in https://github.com/Regalis11/Barotrauma-development/commit/11d034313678b8625daa415befadcd8555036dc4

[NilanthAnimosus]

Tested against dev commit https://github.com/Regalis11/Barotrauma-development/commit/f60a2ad003be4fcf1fd3e7d6c675a3f0dbcce861, works correctly. closing.