Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Fc multi position #5

Open
bbday opened this issue Sep 28, 2023 · 8 comments
Open

New Fc multi position #5

bbday opened this issue Sep 28, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@bbday
Copy link

bbday commented Sep 28, 2023

Do you have plan to fix it for new fc24?
cause now is possible same player can autoswitch position then a CM player can be also at same time RB and get bonus for chemistry

@Regista6
Copy link
Owner

Yeah, I've asked the author of the tool I am using to download Squad CSV to include an additional column for Alternate Positions. Once that is available, this can be implemented. Apart from this, I think only the chemistry of Icons has changed; they now add 1 chem to every league!

@Regista6 Regista6 self-assigned this Sep 28, 2023
@Regista6 Regista6 added the enhancement New feature or request label Sep 28, 2023
@bbday
Copy link
Author

bbday commented Sep 29, 2023

if you need csv that include alternative position no issue i can generate it, usually each player have 2-3 alternative position (let me know it format that you wanna it, like array [CM,LM,RM] example).
I can generate also more efficient csv format with nation, team, club split in other csv than use ID like dictionary (i use this format for me)
Let me know it

@bbday
Copy link
Author

bbday commented Sep 29, 2023

You can use this CSV to make test i use all fifa code then more accurate.
I suggest to use Id cause numbers have more performance than strings (you can use dictionary to retrive name)

https://drive.google.com/file/d/10HFvMCv1-Nw6T7hohPctHO_RbIWaUtWG/view?usp=drive_link

If miss something let me know it

@Regista6
Copy link
Owner

The tool has been updated. Currently, the dataset looks like this:

Name Rating Rarity Preferred Position Nation League Team Price Limits Last Sale Price Discard Value Contract Untradeable Loans DefinitionId IsDuplicate IsInActive11 Alternate Positions ExternalPrice
Miedema 86 Rare ST Netherlands Barclays WSL Arsenal --NA-- 0 0 7 TRUE TRUE 233746 FALSE TRUE CAM,CF,ST 7000

I am thinking of just creating separate entries of a particular player for each position. Also would like to access your dataset as well. Thanks!

@bbday
Copy link
Author

bbday commented Oct 6, 2023

my data comming from EA player iteration.
Atm main change is same player have mutiple positions and chemistry bonus for club is valid if club name is name (male/female) cause clubId is different number.

I think to use extra value like ClubMFId use same code id male/female for chemistry calc
For multiple position atm i dont have any idea except your but will increase 4 iterations

@Regista6
Copy link
Owner

Regista6 commented Oct 6, 2023

Many thanks for taking an interest in this project. Can you grant access to your drive link above?

In the above example, Miedema has club listed as Arsenal. If for female players, this consistency is maintained, then it will be fine, I think!

Dataset size will definitely increase (x3 approximately if we consider each player can play in 3 positions). But how much it will impact solver performance remains to be seen.

@bbday
Copy link
Author

bbday commented Oct 6, 2023

sorry i didnt realize need access to see it

@Regista6
Copy link
Owner

Regista6 commented Oct 8, 2023

In your dataset, male and female players have different club IDs for the same club name. One of my intentions was to combine players from club and market. But for that, I would need the entire dataset of players with prices. For now though, the extension to download club csv works well. Also, I've pushed some code to reflect changes made in EA FC 24.

EA FC 24 changes 📈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants