Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL for jsonld from schema.org changed? #197

Closed
MEmanuelsson opened this issue Aug 21, 2020 · 4 comments · Fixed by #202
Closed

URL for jsonld from schema.org changed? #197

MEmanuelsson opened this issue Aug 21, 2020 · 4 comments · Fixed by #202
Labels
bug Issues describing a bug or pull requests fixing a bug.

Comments

@MEmanuelsson
Copy link
Contributor

I just downloded the source code for Schema.NET with the purpose of trying to see if I can find a way to solve this issue #42, if possible. However running the project Schema.NET.Tool results in the application crashing since calling https://schema.org/version/latest/all-layers.jsonld results in status code 404 Not Found.

Looking at https://schema.org/docs/developers.html it seems like this url has changed, probably to https://schema.org/version/latest/schemaorg-current-https.jsonld?

I tried changing to this url and that way I get information from schema.org but that then results in the following exception:

System.Exception: Check that a new primitive type has not been added.
at Schema.NET.Tool.Services.SchemaService.SetParentAndChildren(List`1 classes) in C:\Source\Schema.NET\Tools\Schema.NET.Tool\Services\SchemaService.cs:line 180
at Schema.NET.Tool.Services.SchemaService.GetObjectsAsync() in C:\Source\Schema.NET\Tools\Schema.NET.Tool\Services\SchemaService.cs:line 53
at Schema.NET.Tool.Program.ExecuteAsync() in C:\Source\Schema.NET\Tools\Schema.NET.Tool\Program.cs:line 65
at Schema.NET.Tool.Program.Main() in C:\Source\Schema.NET\Tools\Schema.NET.Tool\Program.cs:line 45

Any input here would be appreciated.
Best regards
Martin

@MEmanuelsson MEmanuelsson added the bug Issues describing a bug or pull requests fixing a bug. label Aug 21, 2020
@RehanSaeed
Copy link
Owner

Hmmm, this is news to me. Would need to confirm from the official schema.org repo what the new URL is and whether they changed the schema in any way.

@MEmanuelsson
Copy link
Contributor Author

I would guess that this pull request is where the change was made in the schema.org repo, schemaorg/schemaorg#2654. Also announced on twitter as it seems: https://twitter.com/danbri/status/1283767294267731971

@RehanSaeed
Copy link
Owner

Thanks @MEmanuelsson for the detective work!

Fixed in #202.

@RehanSaeed
Copy link
Owner

Fix has gone in. Will push a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues describing a bug or pull requests fixing a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants