Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable reflection based destructurer #156

Closed
304NotModified opened this issue Nov 29, 2019 · 5 comments
Closed

disable reflection based destructurer #156

304NotModified opened this issue Nov 29, 2019 · 5 comments
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement.

Comments

@304NotModified
Copy link
Contributor

Hi,

As far as I understand, disabling/replacing the reflection based destructurer isn't an option.

(see also https://stackoverflow.com/questions/59054681/is-it-possible-to-disabled-the-reflection-based-destructurer-in-serilog-exceptions)

Is a PR accepted for this?

@304NotModified 304NotModified added the enhancement Issues describing an enhancement or pull requests adding an enhancement. label Nov 29, 2019
@krajek
Copy link
Collaborator

krajek commented Nov 30, 2019

Hi @304NotModified, thanks for reaching out.

You are right, this is not an option yet. Nobody asked for it and we did not think about it :-).

I am pretty sure that we would agree on backward-compatible change that would allow disabling reflection-based destructurer.

I think I can implement it early next week.

@304NotModified
Copy link
Contributor Author

Cool!

@RehanSaeed
Copy link
Owner

Fixed in #158

@RehanSaeed
Copy link
Owner

5.4.0 released.

@304NotModified
Copy link
Contributor Author

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants