Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation shadow #58

Open
lalmanzar opened this issue Feb 4, 2020 · 1 comment
Open

Elevation shadow #58

lalmanzar opened this issue Feb 4, 2020 · 1 comment
Labels
Discussion Discussion related to project enhancement New feature or request help wanted Extra attention is needed

Comments

@lalmanzar
Copy link

Hi @ReinBentdal, I was wondering why you don't use the Material boxshadows that are already on flutter when using elevation with the default color? that would make it look just like the first-party elevation. This is mostly because they use a combination of 3 shadows "Umbra Penumbra and Ambient Shadow."

https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/shadows.dart

@ReinBentdal
Copy link
Owner

Hi, the reason why i initially decided to not go with the build in material elevation was because i didnt like it as much. However the package has changed over time and i am now more interested in replicating the functionality the flutter team has implemented instead of implementing them in my own way. The problem with changing this now is that it will break widgets made with division and using elevation. I am in general very open for change if its beneficial long term which i think this feature is. I have been a bit inactive the last months due to being busy with other things. If you implement this feature and open a pull request, i will most likely accept it (if implemented right).

@ReinBentdal ReinBentdal added Discussion Discussion related to project enhancement New feature or request help wanted Extra attention is needed labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Discussion related to project enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants