Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Attribute setting calls moved within class #48

Closed
alicerdv opened this issue Dec 23, 2022 · 1 comment
Closed

[Feature] Attribute setting calls moved within class #48

alicerdv opened this issue Dec 23, 2022 · 1 comment

Comments

@alicerdv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, some attributes of an object are set directly within the pipeline. Eg self.model.current_model = None is set in theoretical_performance method of AL pipeline

Describe the solution you'd like
Attributes like this should be methods of the class eg in the example described above, reset_current_model() should be a method in the model class

Additional context
Link to comment where this was mentioned: #33 (comment)

@thomasgaudelet
Copy link
Contributor

addressed in PR #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants