-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random crash while mining with a CC:T turtle #328
Comments
It looks like |
@AViewFromTheTop @Treetrain1 sorry for another ping, but this is related to frozen lib |
Awe, dangit lol |
Threaded world generation assumes that calls to the chunk generator is mostly side-effect-free. It basically means the chunk generator shouldn't modify any global state, such as most static final fields with mutable objects ( EasyNoiseSampler is violating this assumption. |
Rip |
I’d prefer to not create a new instance every single time a feature samples noise, it would be nice if there were a similar enough way to how we have it currently |
You can create a new instance without actually trashing the heap if the object never escapes the method. Also in your current implementation you are creating several instances that is definitely going to end up in the heap when |
Describe the bug
Basically i was casually mining in my basement with a CC:Tweaked turtle (robot block, not the sea mob) and the game crashed. Don't know if this have some relation, honestly.
To Reproduce
Steps to reproduce the behavior:
Runtime info (please complete the following information):
Crash reports / logs
HERE
Other mods
Mod List
Checklist
The text was updated successfully, but these errors were encountered: