Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize Crashlytics logging instead of print statements #79

Closed
alecgorge opened this issue Aug 21, 2018 · 2 comments · Fixed by #91
Closed

Utilize Crashlytics logging instead of print statements #79

alecgorge opened this issue Aug 21, 2018 · 2 comments · Fixed by #91
Milestone

Comments

@alecgorge
Copy link
Member

https://docs.fabric.io/apple/crashlytics/enhanced-reports.html#custom-logging

We should also update AGAudioPlayer/BASS gapless to support a custom logging callback function to track all of this.

@alecgorge
Copy link
Member Author

This looks like a good way to centralize logging: https://github.com/emaloney/CleanroomLogger

os_log seems like a disaster for us: no way to collect anything after it is sent

@farktronix
Copy link
Member

CleanroomLogger #69

For all those reasons and many more that I could expound upon at great length, I will never be adding Cocoapods support to this or any other project I maintain.

This decision is final and will not be revisited. If this rules out CleanroomLogger for you, then I'm sorry this package couldn't meet your needs; I hope you can find one that does.

There are a ton of forks of the project to add a Podspec. I don't see one that appears to be long lived and maintaining a Podspec though. This is the longest lived fork that I could easily find, so I guess we can go with that and make our own fork later if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants