Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC14.0.1 & Audio Player 2.4.1: "App is not compliant" #349

Closed
Sanookmakmak opened this issue Oct 2, 2018 · 5 comments
Closed

NC14.0.1 & Audio Player 2.4.1: "App is not compliant" #349

Sanookmakmak opened this issue Oct 2, 2018 · 5 comments
Assignees
Milestone

Comments

@Sanookmakmak
Copy link

occ app:check-code audioplayer

Invalid appinfo.xml file found: Element 'owncloud': This element is not expected.

Invalid appinfo.xml file found: Element 'types': This element is not expected. Expected is one of ( background-jobs, repair-steps, two-factor-providers, commands, settings, activity, navigations, contactsmenu, collaboration, sabre ).

App is not compliant

What does this mean?
Thank you!

@Rello
Copy link
Owner

Rello commented Oct 3, 2018

Hello,
thank you, I will take care.
its actually not an issue - it seems that the code-checker does not like the sequence of the elements in .xml
I will try to find out how which sequence will make it happy

@Rello Rello self-assigned this Oct 3, 2018
@Rello Rello added this to the 2.5.0 milestone Dec 3, 2018
@Rello
Copy link
Owner

Rello commented Dec 9, 2018

nextcloud/server#12942

@Rello
Copy link
Owner

Rello commented Dec 15, 2018

hello,
this issue is cosmetic as the tags are required (types) or irrelevant for NC (owncloud).
As the app is working on both releases, it has to be kept like that

@Rello Rello closed this as completed Dec 15, 2018
@Rello Rello removed the in progress label Dec 15, 2018
@Rello Rello modified the milestones: 2.5.0, 2.8.0 Aug 15, 2019
@Rello Rello reopened this Aug 15, 2019
@Rello
Copy link
Owner

Rello commented Aug 15, 2019

The types for instances has to follow the namespace tag. https://apps.nextcloud.com/schema/apps/info.xsd

@Rello
Copy link
Owner

Rello commented Aug 16, 2019

types was rearanged.

2 findings remaining

Invalid appinfo.xml file found: Element 'owncloud': 
Invalid appinfo.xml file found: Element 'settings-sections': 

These are OC dependencies and can not be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants