Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when signal lines are shown in a map or in the tracking station #693

Closed
jarosm opened this issue Oct 27, 2016 · 4 comments
Closed

Comments

@jarosm
Copy link

jarosm commented Oct 27, 2016

When signal lines are shown in a map view or in the tracking station, then an error "Trying to create a material from string - this is no longer supported." is generated. This error is generated on scene change and when cycling through displayed connection lines types by clicking on a button in the tracking station.

RT version: RemoteTech-1.8.0-5-develop

Output log: https://dl.dropboxusercontent.com/u/69160140/RemoteTech/output_log.txt
Persistent file: https://dl.dropboxusercontent.com/u/69160140/RemoteTech/persistent.sfs
List of mods: https://dl.dropboxusercontent.com/u/69160140/RemoteTech/mods.txt
(There are three probe relays in the persistent file, which has only stock, RemotechTech and USI Reactor Pack parts)

@neitsa
Copy link
Member

neitsa commented Oct 27, 2016

hello @jarosm, thank you for your bug report!
This is a known issue (problem is located here) : unity doesn't like embedded sharers. A fix would be to move out the shader, compile it to an external file, locate the file within RT and load the shader.

The thing is, we'll soon move RT on top of CommNet and this piece of code we'll be removed in the process. There are other bugs that we'd like to address in the meantime, knowing that this bug we'll disappear with the next major RT version.

I'm still keeping the bug opened, but I can't say it will be fixed in the next minor bug fix release.

Anyway, thanks a lot for your detailed issue report 👍 , it's always a pleasure to have well documented issues.

@neitsa neitsa added this to the 2.0 milestone Oct 27, 2016
@jarosm
Copy link
Author

jarosm commented Oct 27, 2016

I understand. It's not gamebreaking, so I can ignore it :)

@KSP-TaxiService
Copy link
Contributor

KSP-TaxiService commented Aug 15, 2018

Small note: Compiling the shader into an asset bundle will require specific versions of Squad's PartTool and Unity for different KSP versions (eg 1.3 and 1.4).

Edit: Ended up in reusing CommNet's line material to restore to its glory
image

Edit 2: Actually, this issue is two-fold. First, RT line utilised KSP's orbit line but KSP 1.3 switched to the fading line, resulting in RT lines following the same fading and looking weird. Second, the RT's obsolete material even does not work (was null) in KSP 1.3 and above but is transparently superseded by orbit line material.

@PiezPiedPy
Copy link
Contributor

Just tested the pre-release, worked fine for me on KSP 1.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants