Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldn't odometer sensor have state_class total_increasing instead of measurement? #224

Open
thomasdelaet opened this issue Apr 29, 2024 · 2 comments
Open

shouldn't odometer sensor have state_class total_increasing instead of measurement? #224

thomasdelaet opened this issue Apr 29, 2024 · 2 comments
Assignees
@ReneNulschDE
Labels
enhancement New feature or request

Comments

@thomasdelaet
Copy link
Contributor

The problem

odometer currently has measurement state_class which makes it impossible to generate useful statistics-graphs. Shouldn't this be total_increasing instead?

What version of MBAPI2020 do use?

v0.13.0

What was the last working version of MBAPI2020?

No response

What type of installation are you running?

Home Assistant Core

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response
@ReneNulschDE
Copy link
Owner

Thx, yes, this makes sense. Feel free to create a PR. The setting is in the const.py. I'm on vacation with limited access right now.

@ReneNulschDE ReneNulschDE self-assigned this Apr 29, 2024
@ReneNulschDE ReneNulschDE added the enhancement New feature or request label Apr 29, 2024
@thomasdelaet
Copy link
Contributor Author

pull request created: #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ReneNulschDE ReneNulschDE

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomasdelaet @ReneNulschDE