New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swagger spec which uses special characters shows an error dialog #158
Comments
Heard back from Egill:
I'm still not sure what this means for us though: should we change the default encoding for Windows installation and possibly other platforms, and/or just recommend this as a workaround if users encounter the problem? Or is there a better solution? Also, I assume we need to do something with exception handling so that users don't see repeated modal error messages whenever they type in the editor. I've attached the problem source file here. |
The problem looks like JSON only allows UTF encodings, the special character contain in the sample projects were encoded in iso-8859-1 which causes a parsing exception to be thrown. I made the changes to force the parsing of swagger document using UTF-8 encoding. I don't know what's the default file encoding in Eclipse for Windows, but we should encourage users to set it to UTF-8. This can be done in Eclipse > Preferences > General > Workspace > Text file encoding. Link to PR #160 |
I suggest to limit the scope of this issue to the following: See #160 (comment) for details I will extract other parts, e.g. for contentTypes into other issues.
Covered by Use UTF-8 as default content type for JSON, Xtend and RAPID-ML Files
See [https://modelsolv.atlassian.net/browse/ZEN-2894](Create a FAQ item about encodings) |
Removed the High Priority flag. The suggested improvements remaining to be completed are not high priority right now. |
We have a Windows user who uses special characters (from Icelandic alphabet).
The user reported the following error (see https://support.reprezen.com/helpdesk/tickets/133):
I was able to reproduce it on Mac. Note that original encoding is "iso-8859-1":
Also, the spec is invalid because the
host
is not specified:This has high priority
The text was updated successfully, but these errors were encountered: