Side-menu covers content on navigation

[lorenwest]

Describe the bug
When the side-menu is in "cover content" mode, "auto-hide on navigation" doesn't work on all screen resolutions. This causes new content to be hidden after navigation.

To Reproduce
Steps to reproduce the behavior:

1. Set screen width to 600px, and open the side menu
2. Navigate to a page from the side menu, and observe the side menu auto-closing to show selected content
3. Set screen with to 800px, and open the side menu
4. Navigate to a page from the side menu, and observe the side menu hiding the newly selected content.

Expected behavior
When a user chooses to cover their content with a side menu for the purposes of navigation, the side menu should auto hide to show the content they desire once they have made their navigation choice.

Screenshots
[not needed - side menu hiding newly navigated page content]

Host Info (please complete the following information):

• All hosts, even reproducible on the wikijs site

Additional context
Navigation works well in very-small screens (vertical mobile) and very-wide screens (laptop/desktop), but hides new content, confusing users and requiring an extra click to hide the side menu after navigation when running in mid-size screens (iPad, mobile landscape mode, small browser, etc).

The request is to always auto-close the sidebar on navigation if it is currently covering content.

Also - never auto-open the sidebar to cover content when a new page is opened.

[lorenwest]

Is there any feedback on this issue? Would you accept a pull request, or do you disagree with the premise of the problem?

[Fastidious]

The fact is, the sidebar doesn’t close automatically, it only closes when clicked on content. That should be configurable, as I would prefer it always closed, and only to open when the hamburger is clicked.

[lorenwest]

It closes automatically on a small screen, so the logic is in place for this to happen. I'm wondering if this is a bug or if people enjoy navigating when the newly loaded pages are hidden by the menu? If some people enjoy that experience, then yea, a personal option would be appropriate.

[Fastidious]

@lorenwest I have a 27" iMac, I run my browser half that screen, and doesn't close for me, unless I click on the document being viewed. If there is a delay, it is way too long.

As I said before, I would rather control when the sidebar opens, or not, so making it a configurable option would be the best course of action, imo.

[vincent-polite]

Hello, I just downloaded wiki.js to try it, and the side navigation autocovering content on every page load is fast turning into a deal breaker for me. If there's a way to hack the css or do something to change this behavior, PLEASE make this happen? From a default behavior standpoint, I'd rather have the side nav "push" the content if it's going to be automatically visible every time. Is someone available to look at this issue or provide a fix?

@lorenwest - I DO NOT like navigation covering content pretty much ever, although I could see how that behavior would be preferable on limited width screens. For desktop and beyond, this is a nuisance as I constantly have to close navigation just to read the page I am on.

[NGPixel]

Hello, I just downloaded wiki.js to try it, and the side navigation autocovering content on every page load is fast turning into a deal breaker for me. If there's a way to hack the css or do something to change this behavior, PLEASE make this happen? From a default behavior standpoint, I'd rather have the side nav "push" the content if it's going to be automatically visible every time. Is someone available to look at this issue or provide a fix?

@lorenwest - I DO NOT like navigation covering content pretty much ever, although I could see how that behavior would be preferable on limited width screens. For desktop and beyond, this is a nuisance as I constantly have to close navigation just to read the page I am on.

This is not the intended behavior. It happens when your screen is too small but still larger than mobile. Maximize your window and the sidebar will no longer appear on top of content.

This is being investigated and hopefully a fix will be available soon.

[justinacolmena]

Hello, I just downloaded wiki.js to try it,

Same here.

side navigation autocovering content on every page load

That does occur for me as well in Firefox browser. I have no problem in Google Chrome.

[NGPixel]

Fixed by dd3699b