Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure configuration has a typo #219

Closed
NateV opened this issue Aug 24, 2017 · 1 comment
Closed

Azure configuration has a typo #219

NateV opened this issue Aug 24, 2017 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@NateV
Copy link

NateV commented Aug 24, 2017

Actual behavior

The sample config file has

azure:
    clientID: .....`

But I get an error "OAuth2Strategy requires a clientID option" because server/libs/auth.js has:

passport.use('azure_ad_oauth2', new AzureAdOAuth2Strategy({
    clientID: appconfig.auth.azure.clientId,
    clientSecret: appconfig.auth.azure.clientSecret,`

There is no appconfig.auth.azure.clientId, only a appconfig.auth.azure.clientID.

Expected behavior

I can fill in the provided Azure sign-on config sample to use Azure sign-on.

Steps to reproduce the behavior

Try to use the provided config.yml template for azure sign-on

Steps to fix the error

Either server/libs/auth.js at line 190 can use appconfig.auth.azure.clientID or the sample config.yml file can replace clientID with clientId

@NGPixel NGPixel self-assigned this Aug 24, 2017
@NGPixel NGPixel added the bug Something isn't working label Aug 24, 2017
@NGPixel
Copy link
Member

NGPixel commented Aug 25, 2017

Fixed in 101158f

@NGPixel NGPixel closed this as completed Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants