Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1470 move page failed with page rules #1757

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Fix #1470 move page failed with page rules #1757

merged 1 commit into from
Apr 22, 2020

Conversation

GaliTW
Copy link
Contributor

@GaliTW GaliTW commented Apr 22, 2020

There is a bug mention at #1470. While the server tries to compare the page permission with the page rules, page.sourceLocale or page.sourcePath is not defined in the page object. The actual one must be page.localeCode and page.path. Otherwise, the checkAccess() function will compare undefined with page rules.

@auto-assign auto-assign bot requested a review from NGPixel April 22, 2020 14:52
@NGPixel NGPixel merged commit ac11cd2 into requarks:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGPixel NGPixel NGPixel approved these changes

Assignees

@NGPixel NGPixel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GaliTW @NGPixel