Fix Rocket.Chat auth module #3122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NGPixel is there a specific reason for this to be held back? I would like to update my wiki.js server, but the update depends on this fix because my users are using rocketchat auth. |
NGPixel
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2572, Wiki.js uses the wrong property to access a users' E-Mail address in the Rocket.Chat auth module.
This PR fixes this.
I have tested this change with the current
devbranch on one of my servers and it's working.Rocket.Chat's response contains an array containing all the emails a user has added to Rocket.Chat. The currently used property
emaildoes not exist in the response. Please see https://docs.rocket.chat/api/rest-api/methods/authentication/me.Since we have no option to choose which E-Mail to use for the OAuth mechanism, I just assumed, we take the first one in the array and go for it.
Please tell me, if you are OK with this, since it can be considered as a dirty hack.
I can add some validation that checks, if the array is empty that throws an error or something.