Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

private browsing mode not supported #34

Closed
jsamuel opened this issue Dec 22, 2011 · 1 comment
Closed

private browsing mode not supported #34

jsamuel opened this issue Dec 22, 2011 · 1 comment

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011

imported trac ticket
created: 2009-09-15 08:33:19
reporter: justin

Private browsing mode doesn't currently get special treatment.

There are two major aspects to consider: 1) the whitelist, and 2) the allowed/blocked request information maintained internally so that RequestPolicy knows what to show in the menu.

I think the easiest thing to do that could be considered expected behavior would be to have anything added to the whitelist during private browsing be temporary and have leaving private browsing mode remove all temporarily whitelisted items.

The internally maintained request data is harder to deal with. One option would be to make a copy of internal data when entering private browsing mode and restore that copy when leaving.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2009-09-20 16:03:45
author: justin

Fixed in r276. The way we support private browsing is to only allow temporary whitelisting from the menu during private browsing mode and then clearing the temporary whitelist when leaving private browsing. We'll need to make sure to keep private browsing mode in mind when adding functionality like more debug and request logging, as that info would need to be cleared when leaving private browsing mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant