Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirects from links opened in new tabs can show in menu of original page #36

Open
jsamuel opened this issue Dec 22, 2011 · 3 comments
Open

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011

imported trac ticket
created: 2009-09-15 08:57:55
reporter: justin

Aerik Knapp-Loomis writes:

Currently there's a bug where when you open a new tab and contains a redirect, the tab that you clicked over from will have somehow interacted with RP as if you allowed a request from the second tab.

For example, every time I'm on google reader and I ctrl+click on a link to a new tab that's located at feedproxy.google.com, which is always a redirect, the google reader tab will show that I've allowed a request from feedproxy.google.com.

This issue has been known and reported a few times before and it's time to make a ticket for it. However, I'm not sure how to fix it. There are fundamental issues with lacking information that Firefox makes available to us when we block or allow requests. It may be the case that solving this involves using a lot more DOM inspection for generating the menu, which is something we'd like to avoid for simplicity and speed reasons.

I need to spend some time on this, though, to see if there's an easier fix I'm not thinking of that won't involve complicating !RequestPolicy a lot just to deal with this issue.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-02-20 16:15:42
author: eibwen

Is this still valid?

example.com now redirects to IANA. Locating a site that linked to example.com, and opening it in the background (albeit via middle click) and then checking the menu, there was no entry for example.com.

Whether there should be is another question; however, it seems this has been implemented in the non-user visible forced policies...

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2011-09-05 12:27:56
author: justin

Adding a link to example.com here in the bug so it's easy to manually test.

http://example.com

Indeed, this bug is still an issue.

@dfc
Copy link

dfc commented Jun 24, 2012

I love RequestPolicy, but this bug drives me absolutely nuts. Is their any chance of seeing a fix in 1.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants