Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inform user in menu that chrome:// origins will not be blocked #43

Closed
jsamuel opened this issue Dec 22, 2011 · 1 comment
Closed

inform user in menu that chrome:// origins will not be blocked #43

jsamuel opened this issue Dec 22, 2011 · 1 comment

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011

imported trac ticket
created: 2009-10-05 08:41:24
reporter: justin

This is an extended and better fix for #35. We should display a message in the menu when the user is at a chrome:// url that tells them they cannot block these requests. It should also take care of not displaying any other meaningless data in the menu in the case of an origin whose requests the user aren't allowed to control.

This is also needed because the change in r275 may actually have a side effect of not clearing items from the menu fully when a page is reloaded, for example.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2009-10-05 08:41:56
author: justin

Fixed in r289. Reverted the changes of r275.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant