Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a way to allow individual blocked requests #7

Open
jsamuel opened this issue Dec 22, 2011 · 4 comments
Open

provide a way to allow individual blocked requests #7

jsamuel opened this issue Dec 22, 2011 · 4 comments

Comments

@jsamuel
Copy link
Member

jsamuel commented Dec 22, 2011

imported trac ticket
created: 2009-06-21 16:58:49
reporter: justin

There should be a way to allow individual blocked requests rather than having to allow an entire domain.

Possibly this could go in an "Advanced" submenu off of the main menu (maybe put it where "Request Log" is and stick "Request Log" under "Advanced", as well). Another option would be to add a new submenu to each blocked/allowed destination and under there list the specific blocked/allowed requests. This starts to get complicated on the implementation side due to the way RequestPolicy tracks blocked and allowed requests for generating the menu: that is, not analyzing the DOM (well, only a little) and instead keeping track of requests that the browser tries to make and associating them with the url of the current page. The risk of misleading info increases a lot if RequestPolicy is stating what the individual items on the page are without looking at the DOM. So, RequestPolicy would need to look through the DOM very thoroughly.

(Thanks to RSnake for the suggestion.)

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2009-06-21 21:22:32
author: justin

This could also fulfill a similar user request of being able to see what was blocked for each destination. (Thanks James Bradwell for the request and for [attachment:view-blocked-items-menu-option.png this mockup].)

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2010-05-02 18:08:15
author: eibwen

Is this a request for full URI specificity?

The attached mockup seems to further segregate the policy settings.
See also #100 which tries to address this.

Perhaps #100 and single menuitem to a single dialog "ALL blocked items on page"?

Alternately, #74 with full URI specificity?
This seems the cleanest with the current implementation; however, it does not address #100.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2010-07-31 18:09:55
author: 4qMPV8HA

If possible, I'd like to see this not just configurable through the menu, but via clicking on placeholder elements (e.g. the placeholder images) -- similar to how NoScript lets you selectively permit individual flash items for domains that haven't been whitelisted.

@jsamuel
Copy link
Member Author

jsamuel commented Dec 22, 2011

imported trac comment
created: 2010-08-08 14:21:50
author: justin

Replying to [comment:4 4qMPV8HA]:

If possible, I'd like to see this not just configurable through the menu, but via clicking on placeholder elements (e.g. the placeholder images)

This feature request was also emailed to me by a user, so I've opened #129 it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant