Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to check #26

Merged
merged 7 commits into from Jan 12, 2022
Merged

Changes to check #26

merged 7 commits into from Jan 12, 2022

Conversation

laurentheirendt
Copy link
Contributor

  • simplification
  • remove check on file name

@daniele-proverbio, can you check so that we can make #24 work?

Copy link
Collaborator

@daniele-proverbio daniele-proverbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the check on file name? Is it for out testing, or for good? I think it could be a first buffer to avoid them uploading random stuff

@laurentheirendt
Copy link
Contributor Author

I removed the check as I don't see the value in it. Basically, any file can be uploaded with any name. The web interface will rename the file to input-data.xlsx and store it in the input directory. So the name of the input file itself does not matter.

@daniele-proverbio
Copy link
Collaborator

I agree than any wrong file will not pass the subsequent checks, but I would nonetheless alert a ministry employee that he\she's using a wrong file. Their pipeline is to always update this specific file with this specific name (which was agreed upon with the Taskforce); if they change it by accident, I believe they should be notified

@laurentheirendt
Copy link
Contributor Author

Okay fair point - I will put it back then

@daniele-proverbio
Copy link
Collaborator

Ok, let me know when to pull :)

@laurentheirendt
Copy link
Contributor Author

I added it now as a first check and then a warning before moving the file. That way, the file handling/moving/renaming is done as part of the pipeline itself.

@laurentheirendt laurentheirendt marked this pull request as ready for review January 12, 2022 15:05
@daniele-proverbio daniele-proverbio merged commit b0f98b1 into dp_develop Jan 12, 2022
@daniele-proverbio daniele-proverbio deleted the lh-dp_develop-1 branch January 12, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants