New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to check #26
Changes to check #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove the check on file name? Is it for out testing, or for good? I think it could be a first buffer to avoid them uploading random stuff
I removed the check as I don't see the value in it. Basically, any file can be uploaded with any name. The web interface will rename the file to |
I agree than any wrong file will not pass the subsequent checks, but I would nonetheless alert a ministry employee that he\she's using a wrong file. Their pipeline is to always update this specific file with this specific name (which was agreed upon with the Taskforce); if they change it by accident, I believe they should be notified |
Okay fair point - I will put it back then |
Ok, let me know when to pull :) |
I added it now as a first check and then a warning before moving the file. That way, the file handling/moving/renaming is done as part of the pipeline itself. |
@daniele-proverbio, can you check so that we can make #24 work?