Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display totals for mAh, KMs, mins #89

Open
Yes21 opened this issue Dec 3, 2018 · 14 comments
Open

display totals for mAh, KMs, mins #89

Yes21 opened this issue Dec 3, 2018 · 14 comments

Comments

@Yes21
Copy link
Contributor

Yes21 commented Dec 3, 2018

I will try to implement this PR

@RespawnDespair
Copy link
Owner

It should be doable in the osd-orig repository. The code is largely the same.

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 3, 2018

What do you mean ?
Is this code already here : https://github.com/RespawnDespair/wifibroadcast-osd ?

@RespawnDespair
Copy link
Owner

No i meant you need to change the code here:
https://github.com/RespawnDespair/wifibroadcast-osd-orig
The modifications should be the same as the original PR.

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 3, 2018

Sorry, I don't understand !
Why should I change the code here https://github.com/RespawnDespair/wifibroadcast-osd-orig, as it's not used to build the image ?

@RespawnDespair
Copy link
Owner

Because it is 😁
I rewrote the osd in wifibroadcast-osd. That didn't work completely. So i added the original osd in the wifibroadcast-osd-orig repository. If you look closely in the 00-run.sh in stage 4 you will see i actually pull the orig repo.

It's not ideal and i want to clean it up in the future.

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 3, 2018

Ahh !! Ok !

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 4, 2018

I can't find "osdconfig.txt".
In the image it's in "/boot" and in "/tmp", but where's that file in the github repos ?

@pilotnbr1
Copy link
Contributor

pilotnbr1 commented Dec 4, 2018

@Yes21 wifibroadcast-image-builder/stages/04-Wifibroadcast/FILES/overlay/boot/osdconfig.txt

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 4, 2018

Thanks.
I'm working on it ...

@pilotnbr1
Copy link
Contributor

👍 🙂

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 5, 2018

I did 2 PRs :
#92
RespawnDespair/wifibroadcast-osd-orig#1

It builds ok, but can't see anything new to the OSD.
Perhaps because all these values are supposed to be null in my test case ...

@Yes21
Copy link
Contributor Author

Yes21 commented Dec 5, 2018

@wowi69 Could you check if the code is well implemented ?

osdconfig.txt is here : https://github.com/RespawnDespair/wifibroadcast-image-builder/stages/04-Wifibroadcast/FILES/overlay/boot/osdconfig.txt
render.c and render.h are here : https://github.com/RespawnDespair/wifibroadcast-osd-orig

@pilotnbr1
Copy link
Contributor

So perhaps this improvement can be expanded upon. Rodizio brought up the scenario where the osd can possibly be reset (and counters) mid flight.

Any solutions to avoid this? One idea I had was to monitor the armed status of the uav and only reset counters on a disarm msg. Or possibly only reset counters if the osd has been off for a certain amount of time.

@pilotnbr1
Copy link
Contributor

pilotnbr1 commented Dec 26, 2018

@Yes21 @JelleTigchelaar the PRs in https://github.com/RespawnDespair/wifibroadcast-osd-orig/pulls

are ready. I was not able to test with telemetry. They do display though. Only did the compiling on a PI did not actually use the builder to build them but they should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants