New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
private methods #1321
Comments
Hi, @spider-mane! The reason for that is that it makes it easy to maintain the project. In general I would like to favor composition over inheritance, but it's not like it's a taboo. I've said something about that before #655 (comment) Which class would you like to change and why? Perhaps you could send your pull request and we could talk over that. |
I was looking to implement a solution where a child Another issue arises when creating the desired implementation from scratch. The project in question needs to be able to reliably anticipate the nature of the But going back to the original issue, despite |
For message templates, you should definitely look into: https://github.com/Respect/Validation/blob/master/docs/message-translation.md The
Those are the recipes for making rules that behave like Availability of custom composite rules in our https://github.com/Respect/Validation/blob/master/docs/concrete-api.md How we deal with these groups of rules is one of the trickiest parts of the library, and there's a bunch of limitations on what we can expose for extensibility while keeping the core compatible with external rules. This is an old issue, and you might not be working on this anymore. If you are still interested in doing so, and by following these steps you encountered a problem, feel free to reopen this. In that case, I would like you to publish a branch with WIP changes so we can also understand better what you're trying to do! 🐼 |
I've noticed a number of private methods and final classes in this project. Is there a specific reason for this? It seems like it's done as a matter of convention. I ask because I'm looking to make a contribution that will most likely require a child class using methods designated as private in a parent.
The text was updated successfully, but these errors were encountered: