Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Iban #1367

Closed
micgay opened this issue Sep 27, 2021 · 1 comment
Closed

Validate Iban #1367

micgay opened this issue Sep 27, 2021 · 1 comment

Comments

@micgay
Copy link

micgay commented Sep 27, 2021

the function bcmod($this->convertToInteger($rearranged), '97') return '1.00' with PHP 7.4
so bcmod($this->convertToInteger($rearranged), '97') === '1' return false
and bcmod($this->convertToInteger($rearranged), '97') == '1'; return true
Please could you fix the issue ?

@alganet
Copy link
Member

alganet commented Feb 16, 2023

I noticed that you're taking about the implementation of Rules\Iban, which I believe has changed since this was opened. It now reads bcmod($this->convertToIntegerAsString($rearranged), '97').

I can't be sure which IBANs were failing for you. If this is still a problem, can you reopen it with some examples of failed IBANs?

Thanks!

@alganet alganet closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants