filter nil event handlers to fix unexpected event target #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respo resolves event by reading
coord
, which is attached to virtual DOM. It binds events on elements and find real virtual element in@*global-element
. However, as introduced in Memof solution, virtual DOM might be reused although there coord might be different. Thus we get a wrong coord. It was not problem in the old time, but when there's an{:click nil}
, it might first check there, and then use the same coord for checking parents, then we get the problem it resolving to the cached element's parents. So this fix tries to get rid of the nil events.