Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty4 update with client local address binding feature #23

Open
JChrist opened this issue Oct 25, 2017 · 1 comment
Open

Netty4 update with client local address binding feature #23

JChrist opened this issue Oct 25, 2017 · 1 comment

Comments

@JChrist
Copy link

JChrist commented Oct 25, 2017

Hello,
I have created a PR (#22) updating the netty 4 branch with latest netty, also pulling in changes from upstream repository (fizzed) that were not brought in this one.
Also, it contains a new feature for an smpp client based on cloudhopper to be able to bind to a specific local address. This is required when running on a server with multiple network addresses and when only a specific one of them is whitelisted in the SMPP server side (and it isn't the one picked up by default).

Are there any plans to check this out, provide feedback and possibly merge it in?

@vetss
Copy link

vetss commented Oct 27, 2017

Hello @JChrist

yes, we are going to check your updates, thanks for summarizing of missed commits for netty-4 branch.
We need some time for finish the work because your update rather heavy, sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants